Verify sy-subrc Promptly After System Calls

WarningSecurity & Robustness#EC CHECK_SUBRCRemote Enabled

Overview

Check sy-subrc after DB, table and string operations.

ATC Finding Message: Check sy-subrc after SELECT SINGLE, READ, AUTHORITY-CHECK, FIND, SEARCH

Rationale

Statements such as SELECT SINGLE, READ TABLE, and AUTHORITY-CHECK report success through sy-subrc. If another statement runs first, the return code is overwritten and the failure is silently ignored. Check sy-subrc immediately, or use a modern expression that handles absence explicitly.

Non-Compliant

SELECT SINGLE customer_id FROM /dmo/customer
  WHERE customer_id = @lv_id
  INTO @lv_customer_id.
process_customer( lv_customer_id ).

Compliant

SELECT SINGLE customer_id FROM /dmo/customer
  WHERE customer_id = @lv_id
  INTO @lv_customer_id.
IF sy-subrc = 0.
  process_customer( lv_customer_id ).
ENDIF.

Configuration & Thresholds

This check can be fine-tuned directly in the ATC Check Variant Editor (CHKV) in Eclipse ADT:

Parameter Name	Data Type	Default Value
CHECK_SELECT_SINGLE	Boolean	true
CHECK_READ_TABLE	Boolean	true
CHECK_AUTHORITY_CHECK	Boolean	true
CHECK_FIND_SEARCH	Boolean	true
CHECK_ASSIGN	Boolean	true

Suppression

To suppress findings for this rule, append the pseudo-comment to the statement:

" Standard pseudo-comment:
... "#EC CHECK_SUBRC

" SAP CI_ prefix format:
... "#EC CI_CHECK_SUBRC

Technical Details

• Native ATC Class: ZCL_SKYLINT_PREF_CHECK_SUBRC
• Implementation File: zcl_skylint_pref_check_subrc.clas.abap