Avoid Explicit COMMIT WORK in Business Logic

WarningSecurity & Robustness#EC COMMIT_WORKLocal Only

Overview

Avoid COMMIT and ROLLBACK in application logic.

ATC Finding Message: Avoid COMMIT/ROLLBACK WORK; transactional control belongs to framework

Rationale

COMMIT WORK inside business logic ends the SAP LUW at an arbitrary point, so later failures cannot roll back earlier changes. Frameworks such as RAP manage the save sequence and commit for you. Let the framework commit and keep the business logic transactional.

Non-Compliant

METHOD save_order.
  UPDATE zorder SET status = @lv_status WHERE order_id = @lv_id.
  COMMIT WORK.
ENDMETHOD.

Compliant

METHOD save_order.
  UPDATE zorder SET status = @lv_status WHERE order_id = @lv_id.
ENDMETHOD.

Suppression

To suppress findings for this rule, append the pseudo-comment to the statement:

" Standard pseudo-comment:
... "#EC COMMIT_WORK

" SAP CI_ prefix format:
... "#EC CI_COMMIT_WORK

Technical Details

• Native ATC Class: ZCL_SKYLINT_NO_COMMIT_WORK
• Implementation File: zcl_skylint_no_commit_work.clas.abap