Limit Member Attributes per Class

WarningMetrics & Complexity Limits#EC ATTRIBUTESRemote Enabled

Overview

Limit class member attributes to prevent God Classes.

ATC Finding Message: Class has too many member attributes; split into cohesive components

Rationale

A class with many member variables tends to own several unrelated responsibilities and becomes a God object. Its state is hard to initialize, test, and reason about, and changes ripple through many methods. Split cohesive fields into smaller domain objects or focused classes.

Non-Compliant

CLASS cl_order DEFINITION PUBLIC CREATE PUBLIC.
  PRIVATE SECTION.
    DATA mv_id TYPE string.
    DATA mv_customer TYPE string.
    DATA mv_status TYPE string.
    DATA mv_total TYPE i.
    DATA mv_currency TYPE string.
    DATA mv_created_at TYPE timestamp.
ENDCLASS.

Compliant

CLASS cl_order DEFINITION PUBLIC CREATE PUBLIC.
  PRIVATE SECTION.
    DATA ms_header TYPE ty_order_header.
    DATA mt_items TYPE ty_order_items.
ENDCLASS.

Configuration & Thresholds

This check can be fine-tuned directly in the ATC Check Variant Editor (CHKV) in Eclipse ADT:

Parameter Name	Data Type	Default Value
MAX_ATTRIBUTES	Integer	5

Suppression

To suppress findings for this rule, append the pseudo-comment to the statement:

" Standard pseudo-comment:
... "#EC ATTRIBUTES

" SAP CI_ prefix format:
... "#EC CI_ATTRIBUTES

Technical Details

• Native ATC Class: ZCL_SKYLINT_MAX_ATTRIBUTES
• Implementation File: zcl_skylint_max_attributes.clas.abap